обнаружение края не работает! последний индекс в 2D-массиве пикселей не выходит должным образом

мои извинения за неаккуратный код или неправильно отформатированный вопрос, это мой первый пост!

основная суть этого блока кода заключается в применении обнаружения границ с помощью оператора sobel. у меня есть цикл for, вложенный в цикл for для перебора отдельных пикселей, и другой вложенный цикл for для перебора меньшего 2D-массива для применения оператора sobel, но последняя строка пикселей и часть правого края не разрешаются правильно. огромное спасибо!

#include <math.h>
#include "helpers.h"

//prototype functions
void calcVert (int h, int w, int height, int width, RGBTRIPLE temp[height][width], int *blue, int *green, int *red);
void calcHori (int h, int w, int height, int width, RGBTRIPLE temp[height][width], int *blue, int *green, int *red);

// Detect edges
void edges(int height, int width, RGBTRIPLE image[height][width])
{
    int sobelBlueV;
    int sobelGreenV;
    int sobelRedV;
    int sobelBlueH;
    int sobelGreenH;
    int sobelRedH;
    RGBTRIPLE temp[height][width];
    for (int h = 0; h < height; h++)
    {
        for (int w = 0; w < width; w++)
        {
            temp[h][w].rgbtBlue = image[h][w].rgbtBlue;
            temp[h][w].rgbtGreen = image[h][w].rgbtGreen;
            temp[h][w].rgbtRed = image[h][w].rgbtRed;
        }
    }
    for (int h = 0; h < height; h++)
    {
        for (int w = 0; w < width; w++)
        {
            /*
            [-1] [0] [+1]    [+1] [+2] [+1]
            [-2] [0] [+2]    [0 ] [0 ] [0 ]
            [-1] [0] [+1]    [-1] [-2] [-1]
            
            */
            calcVert(h, w, height, width, temp, &sobelBlueV, &sobelGreenV, &sobelRedV);
            calcHori(h, w, height, width, temp, &sobelBlueH, &sobelGreenH, &sobelRedH);
            // ^2 and sqrt
            int bluePoint = round(sqrt(pow(sobelBlueV, 2) + pow(sobelBlueH, 2)));
            if (bluePoint > 255) bluePoint = 255;
            int GreenPoint = round(sqrt(pow(sobelGreenV, 2) + pow(sobelGreenH, 2)));
            if (GreenPoint > 255) GreenPoint = 255;
            int RedPoint = round(sqrt(pow(sobelRedV, 2) + pow(sobelRedH, 2)));
            if (RedPoint > 255) RedPoint = 255;
            image[h][w].rgbtBlue = bluePoint;
            image[h][w].rgbtGreen = GreenPoint;
            image[h][w].rgbtRed = RedPoint;
            
            
        }
    }
}
void calcVert (int h, int w, int height, int width, RGBTRIPLE temp[height][width], int *blue, int *green, int *red)
{
            //row 1: [-1] [0] [+1]
            //row 2: [-2] [0] [+2]
            //row 3: [-1] [0] [+1] vertical kernel
    int cellCalc = 0;
    int totalRed = 0;
    int totalBlue = 0;
    int totalGreen = 0;
    //row 1
    for (int relativeH = -1; relativeH <= 1; relativeH++)
    {
        for (int relativeW = -1; relativeW <= 1; relativeW++)
        {
            //overreach cases
            if (h + relativeH < 0 && w + relativeW < 0)//top left corner
            {
                //set cell values
                if (relativeH == 0 && relativeW == -1) cellCalc = 0;
                if (relativeH == -1 && relativeW == -1) cellCalc = 0;
                if (relativeH == 1 && relativeW == -1) cellCalc = 0;
                if (relativeW == 0) cellCalc = 0;
                if (relativeH == -1 && relativeW == 1) cellCalc = 0;
                if (relativeH == 1 && relativeW == 1) cellCalc = 1;
                if (relativeH == 0 && relativeW ==1) cellCalc = 2;
                
                totalBlue += ((temp[h + relativeH][w + relativeW].rgbtBlue) * cellCalc);
                totalGreen += ((temp[h + relativeH][w + relativeW].rgbtGreen) * cellCalc);
                totalRed += ((temp[h + relativeH][w + relativeW].rgbtRed) * cellCalc);
                
                *blue = totalBlue;
                *green = totalGreen;
                *red = totalRed;
            }
            else if (h + relativeH < 0 && w + relativeW >= width)//top right corner
            {
                //set cell values
                if (relativeH == 0 && relativeW == -1) cellCalc = -2;
                if (relativeH == -1 && relativeW == -1) cellCalc = 0;
                if (relativeH == 1 && relativeW == -1) cellCalc = -1;
                if (relativeW == 0) cellCalc = 0;
                if (relativeH == -1 && relativeW == 1) cellCalc = 0;
                if (relativeH == 1 && relativeW == 1) cellCalc = 0;
                if (relativeH == 0 && relativeW ==1) cellCalc = 0;
                
                totalBlue += ((temp[h + relativeH][w + relativeW].rgbtBlue) * cellCalc);
                totalGreen += ((temp[h + relativeH][w + relativeW].rgbtGreen) * cellCalc);
                totalRed += ((temp[h + relativeH][w + relativeW].rgbtRed) * cellCalc);
                
                *blue = totalBlue;
                *green = totalGreen;
                *red = totalRed;
            }
            else if (h + relativeH < 0)//top edge
            {
                //set cell values
                if (relativeH == 0 && relativeW == -1) cellCalc = -2;
                if (relativeH == -1 && relativeW == -1) cellCalc = 0;
                if (relativeH == 1 && relativeW == -1) cellCalc = -1;
                if (relativeW == 0) cellCalc = 0;
                if (relativeH == -1 && relativeW == 1) cellCalc = 0;
                if (relativeH == 1 && relativeW == 1) cellCalc = 1;
                if (relativeH == 0 && relativeW ==1) cellCalc = 2;
                
                totalBlue += ((temp[h + relativeH][w + relativeW].rgbtBlue) * cellCalc);
                totalGreen += ((temp[h + relativeH][w + relativeW].rgbtGreen) * cellCalc);
                totalRed += ((temp[h + relativeH][w + relativeW].rgbtRed) * cellCalc);
                
                *blue = totalBlue;
                *green = totalGreen;
                *red = totalRed;
            }
            else if (w + relativeW < 0 && h + relativeH >= height)//bottom left corner
            {
                //set cell values
                if (relativeH == 0 && relativeW == -1) cellCalc = 0;
                if (relativeH == -1 && relativeW == -1) cellCalc = 0;
                if (relativeH == 1 && relativeW == -1) cellCalc = 0;
                if (relativeW == 0) cellCalc = 0;
                if (relativeH == -1 && relativeW == 1) cellCalc = 1;
                if (relativeH == 1 && relativeW == 1) cellCalc = 0;
                if (relativeH == 0 && relativeW ==1) cellCalc = 2;
                
                totalBlue += ((temp[h + relativeH][w + relativeW].rgbtBlue) * cellCalc);
                totalGreen += ((temp[h + relativeH][w + relativeW].rgbtGreen) * cellCalc);
                totalRed += ((temp[h + relativeH][w + relativeW].rgbtRed) * cellCalc);
                
                *blue = totalBlue;
                *green = totalGreen;
                *red = totalRed;
            }
            else if (w + relativeW < 0)//left edge
            {
                //set cell values
                if (relativeH == 0 && relativeW == -1) cellCalc = 0;
                if (relativeH == -1 && relativeW == -1) cellCalc = 0;
                if (relativeH == 1 && relativeW == -1) cellCalc = 0;
                if (relativeW == 0) cellCalc = 0;
                if (relativeH == -1 && relativeW == 1) cellCalc = 1;
                if (relativeH == 1 && relativeW == 1) cellCalc = 1;
                if (relativeH == 0 && relativeW ==1) cellCalc = 2;
                
                totalBlue += ((temp[h + relativeH][w + relativeW].rgbtBlue) * cellCalc);
                totalGreen += ((temp[h + relativeH][w + relativeW].rgbtGreen) * cellCalc);
                totalRed += ((temp[h + relativeH][w + relativeW].rgbtRed) * cellCalc);
                
                *blue = totalBlue;
                *green = totalGreen;
                *red = totalRed;
            }
            else if (h + relativeH >= height && w + relativeW >= width)//bottom right corner
            {
                //set cell values
                if (relativeH == 0 && relativeW == -1) cellCalc = -2;
                if (relativeH == -1 && relativeW == -1) cellCalc = -1;
                if (relativeH == 1 && relativeW == -1) cellCalc = 0;
                if (relativeW == 0) cellCalc = 0;
                if (relativeH == -1 && relativeW == 1) cellCalc = 0;
                if (relativeH == 1 && relativeW == 1) cellCalc = 0;
                if (relativeH == 0 && relativeW ==1) cellCalc = 0;
                
                totalBlue += ((temp[h + relativeH][w + relativeW].rgbtBlue) * cellCalc);
                totalGreen += ((temp[h + relativeH][w + relativeW].rgbtGreen) * cellCalc);
                totalRed += ((temp[h + relativeH][w + relativeW].rgbtRed) * cellCalc);
                
                *blue = totalBlue;
                *green = totalGreen;
                *red = totalRed;
            }
            else if (w + relativeW >= width)//right edge
            {
                //set cell values
                if (relativeH == 0 && relativeW == -1) cellCalc = -2;
                if (relativeH == -1 && relativeW == -1) cellCalc = -1;
                if (relativeH == 1 && relativeW == -1) cellCalc = -1;
                if (relativeW == 0) cellCalc = 0;
                if (relativeH == -1 && relativeW == 1) cellCalc = 0;
                if (relativeH == 1 && relativeW == 1) cellCalc = 0;
                if (relativeH == 0 && relativeW ==1) cellCalc = 0;
                
                totalBlue += ((temp[h + relativeH][w + relativeW].rgbtBlue) * cellCalc);
                totalGreen += ((temp[h + relativeH][w + relativeW].rgbtGreen) * cellCalc);
                totalRed += ((temp[h + relativeH][w + relativeW].rgbtRed) * cellCalc);
                
                *blue = totalBlue;
                *green = totalGreen;
                *red = totalRed;
            }
            else //valid cases
            {
                //set cell values
                if (relativeH == 0 && relativeW == -1) cellCalc = -2;
                if (relativeH == -1 && relativeW == -1) cellCalc = -1;
                if (relativeH == 1 && relativeW == -1) cellCalc = -1;
                if (relativeW == 0) cellCalc = 0;
                if (relativeH == -1 && relativeW == 1) cellCalc = 1;
                if (relativeH == 1 && relativeW == 1) cellCalc = 1;
                if (relativeH == 0 && relativeW ==1) cellCalc = 2;
                
                totalBlue += ((temp[h + relativeH][w + relativeW].rgbtBlue) * cellCalc);
                totalGreen += ((temp[h + relativeH][w + relativeW].rgbtGreen) * cellCalc);
                totalRed += ((temp[h + relativeH][w + relativeW].rgbtRed) * cellCalc);
                
                *blue = totalBlue;
                *green = totalGreen;
                *red = totalRed;
            }
        }
    }
}

void calcHori (int h, int w, int height, int width, RGBTRIPLE temp[height][width], int *blue, int *green, int *red)
{
            //row 1: [+1] [+2] [+1]
            //row 2: [ 0] [ 0] [ 0]
            //row 3: [-1] [-2] [-1]
    int cellCalc = 0;
    int totalRed = 0;
    int totalBlue = 0;
    int totalGreen = 0;
    //row 1
    for (int relativeH = -1; relativeH <= 1; relativeH++)
    {
        for (int relativeW = -1; relativeW <= 1; relativeW++)
        {
            //overreach cases
            if (h + relativeH < 0 && w + relativeW < 0)//top left corner
            {
                if (relativeH == -1 && relativeW == -1) cellCalc = 0;
                if (relativeH == -1 && relativeW == 0) cellCalc = 0;
                if (relativeH == -1 && relativeW == 1) cellCalc = 0;
                if (relativeH == 0) cellCalc = 0;
                if (relativeH == 1 && relativeW == -1) cellCalc = 0;
                if (relativeH == 1 && relativeW == 0) cellCalc = 2;
                if (relativeH == 1 && relativeW == 1) cellCalc = 1;
            }
            else if (h + relativeH < 0 && w + relativeW >= width)//top right corner
            {
                //set cell values
                if (relativeH == -1 && relativeW == -1) cellCalc = 0;
                if (relativeH == -1 && relativeW == 0) cellCalc = 0;
                if (relativeH == -1 && relativeW == 1) cellCalc = 0;
                if (relativeH == 0) cellCalc = 0;
                if (relativeH == 1 && relativeW == -1) cellCalc = 1;
                if (relativeH == 1 && relativeW == 0) cellCalc = 2;
                if (relativeH == 1 && relativeW == 1) cellCalc = 0;
                
                totalBlue += ((temp[h + relativeH][w + relativeW].rgbtBlue) * cellCalc);
                totalGreen += ((temp[h + relativeH][w + relativeW].rgbtGreen) * cellCalc);
                totalRed += ((temp[h + relativeH][w + relativeW].rgbtRed) * cellCalc);
                
                *blue = totalBlue;
                *green = totalGreen;
                *red = totalRed;
            }
            else if (h + relativeH < 0)//top edge
            {
                //set cell values
                if (relativeH == -1 && relativeW == -1) cellCalc = 0;
                if (relativeH == -1 && relativeW == 0) cellCalc = 0;
                if (relativeH == -1 && relativeW == 1) cellCalc = 0;
                if (relativeH == 0) cellCalc = 0;
                if (relativeH == 1 && relativeW == -1) cellCalc = 1;
                if (relativeH == 1 && relativeW == 0) cellCalc = 2;
                if (relativeH == 1 && relativeW == 1) cellCalc = 1;
                
                totalBlue += ((temp[h + relativeH][w + relativeW].rgbtBlue) * cellCalc);
                totalGreen += ((temp[h + relativeH][w + relativeW].rgbtGreen) * cellCalc);
                totalRed += ((temp[h + relativeH][w + relativeW].rgbtRed) * cellCalc);
                
                *blue = totalBlue;
                *green = totalGreen;
                *red = totalRed;
            }
            else if (w + relativeW < 0 && h + relativeH >= height)//bottom left corner
            {
                //set cell values
                if (relativeH == -1 && relativeW == -1) cellCalc = 0;
                if (relativeH == -1 && relativeW == 0) cellCalc = -2;
                if (relativeH == -1 && relativeW == 1) cellCalc = -1;
                if (relativeH == 0) cellCalc = 0;
                if (relativeH == 1 && relativeW == -1) cellCalc = 0;
                if (relativeH == 1 && relativeW == 0) cellCalc = 0;
                if (relativeH == 1 && relativeW == 1) cellCalc = 0;
                
                totalBlue += ((temp[h + relativeH][w + relativeW].rgbtBlue) * cellCalc);
                totalGreen += ((temp[h + relativeH][w + relativeW].rgbtGreen) * cellCalc);
                totalRed += ((temp[h + relativeH][w + relativeW].rgbtRed) * cellCalc);
                
                *blue = totalBlue;
                *green = totalGreen;
                *red = totalRed;
            }
            else if (w + relativeW < 0)//left edge
            {
                //set cell values
                if (relativeH == -1 && relativeW == -1) cellCalc = 0;
                if (relativeH == -1 && relativeW == 0) cellCalc = -2;
                if (relativeH == -1 && relativeW == 1) cellCalc = -1;
                if (relativeH == 0) cellCalc = 0;
                if (relativeH == 1 && relativeW == -1) cellCalc = 0;
                if (relativeH == 1 && relativeW == 0) cellCalc = 2;
                if (relativeH == 1 && relativeW == 1) cellCalc = 1;
                
                totalBlue += ((temp[h + relativeH][w + relativeW].rgbtBlue) * cellCalc);
                totalGreen += ((temp[h + relativeH][w + relativeW].rgbtGreen) * cellCalc);
                totalRed += ((temp[h + relativeH][w + relativeW].rgbtRed) * cellCalc);
                
                *blue = totalBlue;
                *green = totalGreen;
                *red = totalRed;
            }
            else if (h + relativeH >= height && w + relativeW >= width)//bottom right corner
            {
                //set cell values
                if (relativeH == -1 && relativeW == -1) cellCalc = -1;
                if (relativeH == -1 && relativeW == 0) cellCalc = -2;
                if (relativeH == -1 && relativeW == 1) cellCalc = 0;
                if (relativeH == 0) cellCalc = 0;
                if (relativeH == 1 && relativeW == -1) cellCalc = 0;
                if (relativeH == 1 && relativeW == 0) cellCalc = 0;
                if (relativeH == 1 && relativeW == 1) cellCalc = 0;
                
                totalBlue += ((temp[h + relativeH][w + relativeW].rgbtBlue) * cellCalc);
                totalGreen += ((temp[h + relativeH][w + relativeW].rgbtGreen) * cellCalc);
                totalRed += ((temp[h + relativeH][w + relativeW].rgbtRed) * cellCalc);
                
                *blue = totalBlue;
                *green = totalGreen;
                *red = totalRed;
            }
            else if (w + relativeW >= width)//right edge
            {
                //set cell values
                if (relativeH == -1 && relativeW == -1) cellCalc = -1;
                if (relativeH == -1 && relativeW == 0) cellCalc = -2;
                if (relativeH == -1 && relativeW == 1) cellCalc = 0;
                if (relativeH == 0) cellCalc = 0;
                if (relativeH == 1 && relativeW == -1) cellCalc = 1;
                if (relativeH == 1 && relativeW == 0) cellCalc = 2;
                if (relativeH == 1 && relativeW == 1) cellCalc = 0;
                
                totalBlue += ((temp[h + relativeH][w + relativeW].rgbtBlue) * cellCalc);
                totalGreen += ((temp[h + relativeH][w + relativeW].rgbtGreen) * cellCalc);
                totalRed += ((temp[h + relativeH][w + relativeW].rgbtRed) * cellCalc);
                
                *blue = totalBlue;
                *green = totalGreen;
                *red = totalRed;
            }
            else //valid cases
            {
                //set cell values
                if (relativeH == -1 && relativeW == -1) cellCalc = -1;
                if (relativeH == -1 && relativeW == 0) cellCalc = -2;
                if (relativeH == -1 && relativeW == 1) cellCalc = -1;
                if (relativeH == 0) cellCalc = 0;
                if (relativeH == 1 && relativeW == -1) cellCalc = 1;
                if (relativeH == 1 && relativeW == 0) cellCalc = 2;
                if (relativeH == 1 && relativeW == 1) cellCalc = 1;
                
                totalBlue += ((temp[h + relativeH][w + relativeW].rgbtBlue) * cellCalc);
                totalGreen += ((temp[h + relativeH][w + relativeW].rgbtGreen) * cellCalc);
                totalRed += ((temp[h + relativeH][w + relativeW].rgbtRed) * cellCalc);
                
                *blue = totalBlue;
                *green = totalGreen;
                *red = totalRed;
            }
        }
    }
}

c cs50 image-processing sobel
person Juan Cardenas    schedule 15.09.2020    source источник

Ответы (1)


arrow_upward
0
arrow_downward

Ваш код действительно сложен и из-за количества тестов на пиксель довольно неэффективен. Я настоятельно рекомендую вам переписать функцию со следующей структурой:

  • обработка первой строки;

  • обработка петель на внутренних рядах;

  • обработка последней строки;

и для каждой строки

  • обработка первого пикселя;

  • обработка петли на внутренних столбиках;

  • обработка последнего пикселя.

Для применения ядер не используйте двойной цикл, а жестко закодируйте формулу (на самом деле членов шесть, а не девять). Разделение обработки на девять экземпляров позволяет четко специализировать код на границах.

Чтобы избежать повторений для компонентов RGB, вы можете использовать вспомогательные функции с некоторой надеждой, что они будут встроены компилятором.

person Yves Daoust    schedule 15.09.2020
comment
Вы бы по-прежнему рекомендовали разделить вертикальную и горизонтальную обработку на 2 разные функции или мне следует их объединить? - person Juan Cardenas; 15.09.2020
comment
@JuanCardenas: вам нужно 9 различных функций, которые одновременно выполняют H / V (18, если вы разделите). Вы также можете использовать одну функцию, которая работает на любой границе с тестами, и одну посередине без тестов. Есть много вариантов. - person Yves Daoust; 16.09.2020